Fix missing require_reauthentication_to_approve in API
What does this MR do and why?
Fix missing require_reauthentication_to_approve in API
-
The project level approval configuration API was missing declaration for the require_reauthentication_to_approve parameters after the changes introduced in: !150710 (merged)
-
Reported in: https://gitlab.com/gitlab-org/gitlab/-/issues/467637+s
-
Related: Rename require_password_to_approve (#431346) • Sam Figueroa • 17.3 • At risk
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Run these curl commands to validate on the command line
curl --location --request PUT 'localhost:3000/api/v4/projects/<ID_OF_A_PROJECT_ON_ULTIMATE_PROJECT>/approvals' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--header 'Authorization: Bearer <TOUR PERSONAL ACCESS TOKEN>' \
--data-urlencode 'require_password_to_approve=true'
curl --location 'localhost:3000/api/v4/projects/<ID_OF_A_PROJECT_ON_ULTIMATE_PROJECT>/approvals' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--header 'Authorization: Bearer <TOUR PERSONAL ACCESS TOKEN>' \
--data-urlencode 'require_reauthentication_to_approve=false'
- Go to the chosen project and navigate to Settings->Merge requests or use rails console to inspect the project.
Edited by Sam Figueroa