Skip to content

Remove imported column from relevant tables

Carla Drago requested to merge 460213-remove-imported-column into master

What does this MR do and why?

This removes the imported column from a number of tables. It was added as part of work for 424454 but a change in the implementation approach meant the column is no longer needed.

The effected Tables are:

design_management_designs
events                    
issues                   
merge_requests           
notes                    
resource_label_events     
resource_milestone_events
resource_state_events   
snippets

This is the second step of the column removal process. The first, to ignore the column, was done with !152620 (merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Rails Migration Output

❯ bundle exec rails db:migrate
main: == [advisory_lock_connection] object_id: 128360, pg_backend_pid: 53390
main: == 20240617160520 RemoveImportedColumnOnDesignManagementDesigns: migrating ====
main: -- remove_column(:design_management_designs, :imported)
main:    -> 0.0105s
main: == 20240617160520 RemoveImportedColumnOnDesignManagementDesigns: migrated (0.0144s) 

main: == [advisory_lock_connection] object_id: 128360, pg_backend_pid: 53390
ci: == [advisory_lock_connection] object_id: 128600, pg_backend_pid: 53392
ci: == 20240617160520 RemoveImportedColumnOnDesignManagementDesigns: migrating ====
ci: -- remove_column(:design_management_designs, :imported)
ci:    -> 0.0052s
ci: == 20240617160520 RemoveImportedColumnOnDesignManagementDesigns: migrated (0.0130s) 

ci: == [advisory_lock_connection] object_id: 128600, pg_backend_pid: 53392
main: == [advisory_lock_connection] object_id: 128880, pg_backend_pid: 53396
main: == 20240617161159 RemoveImportedColumnOnEvents: migrating =====================
main: -- remove_column(:events, :imported)
main:    -> 0.0012s
main: == 20240617161159 RemoveImportedColumnOnEvents: migrated (0.0040s) ============

main: == [advisory_lock_connection] object_id: 128880, pg_backend_pid: 53396
ci: == [advisory_lock_connection] object_id: 129220, pg_backend_pid: 53398
ci: == 20240617161159 RemoveImportedColumnOnEvents: migrating =====================
ci: -- remove_column(:events, :imported)
ci:    -> 0.0018s
ci: == 20240617161159 RemoveImportedColumnOnEvents: migrated (0.0189s) ============

ci: == [advisory_lock_connection] object_id: 129220, pg_backend_pid: 53398
main: == [advisory_lock_connection] object_id: 129840, pg_backend_pid: 53401
main: == 20240617161346 RemoveImportedColumnOnIssues: migrating =====================
main: -- remove_column(:issues, :imported)
main:    -> 0.0015s
main: == 20240617161346 RemoveImportedColumnOnIssues: migrated (0.0046s) ============

main: == [advisory_lock_connection] object_id: 129840, pg_backend_pid: 53401
ci: == [advisory_lock_connection] object_id: 130160, pg_backend_pid: 53403
ci: == 20240617161346 RemoveImportedColumnOnIssues: migrating =====================
ci: -- remove_column(:issues, :imported)
ci:    -> 0.0020s
ci: == 20240617161346 RemoveImportedColumnOnIssues: migrated (0.0095s) ============

ci: == [advisory_lock_connection] object_id: 130160, pg_backend_pid: 53403
main: == [advisory_lock_connection] object_id: 130800, pg_backend_pid: 53406
main: == 20240617161502 RemoveImportedColumnOnMergeRequests: migrating ==============
main: -- remove_column(:merge_requests, :imported)
main:    -> 0.0029s
main: == 20240617161502 RemoveImportedColumnOnMergeRequests: migrated (0.0060s) =====

main: == [advisory_lock_connection] object_id: 130800, pg_backend_pid: 53406
ci: == [advisory_lock_connection] object_id: 131120, pg_backend_pid: 53408
ci: == 20240617161502 RemoveImportedColumnOnMergeRequests: migrating ==============
ci: -- remove_column(:merge_requests, :imported)
ci:    -> 0.0020s
ci: == 20240617161502 RemoveImportedColumnOnMergeRequests: migrated (0.0092s) =====

ci: == [advisory_lock_connection] object_id: 131120, pg_backend_pid: 53408
main: == [advisory_lock_connection] object_id: 131580, pg_backend_pid: 53411
main: == 20240617161555 RemoveImportedColumnOnNotes: migrating ======================
main: -- remove_column(:notes, :imported)
main:    -> 0.0018s
main: == 20240617161555 RemoveImportedColumnOnNotes: migrated (0.0050s) =============

main: == [advisory_lock_connection] object_id: 131580, pg_backend_pid: 53411
ci: == [advisory_lock_connection] object_id: 132040, pg_backend_pid: 53413
ci: == 20240617161555 RemoveImportedColumnOnNotes: migrating ======================
ci: -- remove_column(:notes, :imported)
ci:    -> 0.0026s
ci: == 20240617161555 RemoveImportedColumnOnNotes: migrated (0.0121s) =============

ci: == [advisory_lock_connection] object_id: 132040, pg_backend_pid: 53413
main: == [advisory_lock_connection] object_id: 132460, pg_backend_pid: 53416
main: == 20240617161643 RemoveImportedColumnOnResourceLabelEvents: migrating ========
main: -- remove_column(:resource_label_events, :imported)
main:    -> 0.0012s
main: == 20240617161643 RemoveImportedColumnOnResourceLabelEvents: migrated (0.0039s) 

main: == [advisory_lock_connection] object_id: 132460, pg_backend_pid: 53416
ci: == [advisory_lock_connection] object_id: 133020, pg_backend_pid: 53418
ci: == 20240617161643 RemoveImportedColumnOnResourceLabelEvents: migrating ========
ci: -- remove_column(:resource_label_events, :imported)
ci:    -> 0.0023s
ci: == 20240617161643 RemoveImportedColumnOnResourceLabelEvents: migrated (0.0094s) 

ci: == [advisory_lock_connection] object_id: 133020, pg_backend_pid: 53418
main: == [advisory_lock_connection] object_id: 133440, pg_backend_pid: 53423
main: == 20240617161753 RemoveImportedColumnOnResourceMilestoneEvents: migrating ====
main: -- remove_column(:resource_milestone_events, :imported)
main:    -> 0.0011s
main: == 20240617161753 RemoveImportedColumnOnResourceMilestoneEvents: migrated (0.0041s) 

main: == [advisory_lock_connection] object_id: 133440, pg_backend_pid: 53423
ci: == [advisory_lock_connection] object_id: 133820, pg_backend_pid: 53425
ci: == 20240617161753 RemoveImportedColumnOnResourceMilestoneEvents: migrating ====
ci: -- remove_column(:resource_milestone_events, :imported)
ci:    -> 0.0010s
ci: == 20240617161753 RemoveImportedColumnOnResourceMilestoneEvents: migrated (0.0107s) 

ci: == [advisory_lock_connection] object_id: 133820, pg_backend_pid: 53425
main: == [advisory_lock_connection] object_id: 134360, pg_backend_pid: 53428
main: == 20240617161845 RemoveImportedColumnOnResourceStateEvents: migrating ========
main: -- remove_column(:resource_state_events, :imported)
main:    -> 0.0009s
main: == 20240617161845 RemoveImportedColumnOnResourceStateEvents: migrated (0.0039s) 

main: == [advisory_lock_connection] object_id: 134360, pg_backend_pid: 53428
ci: == [advisory_lock_connection] object_id: 134820, pg_backend_pid: 53430
ci: == 20240617161845 RemoveImportedColumnOnResourceStateEvents: migrating ========
ci: -- remove_column(:resource_state_events, :imported)
ci:    -> 0.0011s
ci: == 20240617161845 RemoveImportedColumnOnResourceStateEvents: migrated (0.0098s) 

ci: == [advisory_lock_connection] object_id: 134820, pg_backend_pid: 53430
main: == [advisory_lock_connection] object_id: 135280, pg_backend_pid: 53433
main: == 20240617161951 RemoveImportedColumnOnSnippets: migrating ===================
main: -- remove_column(:snippets, :imported)
main:    -> 0.0013s
main: == 20240617161951 RemoveImportedColumnOnSnippets: migrated (0.0040s) ==========

main: == [advisory_lock_connection] object_id: 135280, pg_backend_pid: 53433
ci: == [advisory_lock_connection] object_id: 135600, pg_backend_pid: 53435
ci: == 20240617161951 RemoveImportedColumnOnSnippets: migrating ===================
ci: -- remove_column(:snippets, :imported)
ci:    -> 0.0020s
ci: == 20240617161951 RemoveImportedColumnOnSnippets: migrated (0.0091s) ==========

ci: == [advisory_lock_connection] object_id: 135600, pg_backend_pid: 53435

Related to #460213

Edited by Carla Drago

Merge request reports