Skip to content

E2E: add repeaters to harden verify ide specs

John McDonnell requested to merge jmd/harden-ide-e2e into master

What does this MR do and why?

E2E: add repeaters to harden verify ide specs

During !154802 (merged) we do a large refactor of the WebIDE E2E tests. During monitoring of the changes it was observed in jobs such as https://gitlab.com/gitlab-org/gitlab/-/jobs/7108653064 that with a slow network the check for has_message may be flaky.
I suspect this was previously masked by the slower duration of the suite. We should allow for the test to wait longer to verify the failure message.

These failures should be addressed before Add WebIDE tests to blocking suite (gitlab-org/quality/quality-engineering/team-tasks#2781)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  • The failures have mostly manifested in the instance-image-slow-network job, so attempt to simulate similar conditions locally.
  • NB - If using WEBDRIVER_HEADLESS=false during the file upload process, you will need to manually intervene and close the OS file window (hit cancel) if the test does a 'file upload' otherwise the test may fail. When running in HEADLESS mode this isn't a concern.
  1. QA_SIMULATE_SLOW_CONNECTION=true QA_SLOW_CONNECTION_THROUGHPUT_KBPS=500 QA_SLOW_CONNECTION_LATENCY_MS=75 bundle exec rspec qa/specs/features/browser_ui/3_create/web_ideu/upload_new_file_in_web_ide_spec.rb
Edited by John McDonnell

Merge request reports