Skip to content

Do not audit log encrypted columns

Thong Kuah requested to merge sensitive_attributes_audit_log into master

What does this MR do and why?

Do not audit log encrypted columns

We can audit log that a sensitive column has changed, but not the changes (both from and to values).

This will restore previous behaviour where attr_encrypted columns were not logged. With the upcoming upgrade to attr_encrypted 4.0.0 (explored in !143741), the #{column}_was was fixed for these columns, which requires to now handle #{column}_was, and previous_changes with care.

This best solution thusly is to filter out encrypted column values.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Thong Kuah

Merge request reports