Skip to content

Hide Puma::Server constant in runtime tests

Krasimir Angelov requested to merge ka/broken-master/6869 into master

What does this MR do and why?

Hide Puma::Server in Gitlab::Runtime tests, in case Puma was started by Capybara.

See gitlab-org/quality/engineering-productivity/master-broken-incidents#6869 (comment 1952372006).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. On master, run bundle exec rspec spec/lib/search/settings_spec.rb spec/lib/gitlab/runtime_spec.rb, spec/lib/gitlab/runtime_spec.rb should fail.
  2. On this branch, run bundle exec rspec spec/lib/search/settings_spec.rb spec/lib/gitlab/runtime_spec.rb, spec/lib/gitlab/runtime_spec.rb should succeed.

Merge request reports