Skip to content

Properly delete files when a package is removed

Alessio Caiazza requested to merge ac-fix-packages-deletion into master

What does this MR do?

Both CarrierWave and ProjectStatistics relies on record deletion to cleanup storage and update statistics.

We delete Packages instead of PackageFiles and the record deletion is performed by the DB.

This MR introduces a dependent: :destroy on Package-PackageFiles relation to make sure that when a package is deleted all its files are properly disposed of.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Relevant issues:

  • related to gitlab-org/gitlab-ee#12583
  • related to gitlab-org/gitlab-ee#12581
Edited by Mayra Cabrera

Merge request reports