Skip to content

SPP - Unpushed commits show blob_id instead of commit_id

Serena Fang requested to merge spp-fix-revisions into master

What does this MR do and why?

#460929 (closed)

Bug - when there are secrets in multiple commits, the earlier commit shows blob_id instead of commit_id.

This MR uses changes_access.commits instead of changes_access.changes to look up tree entries that contain secrets. changes_access.changes (bugged) shows the commit ids of the latest pushed changes and your latest staged changes, but "loses" any commits previous to the latest commit that haven't been pushed yet. changes_access.commits has the commit_ids of all unpushed commits. Some more explanation: Slack link

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-06-21_at_3.51.10_PM Screenshot_2024-06-21_at_3.50.23_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Serena Fang

Merge request reports