Skip to content

Improve ProtectedRefAccess#humanize logic

Joe Woodward requested to merge chore/461213-refactory-humanize into master

What does this MR do and why?

Related to branchRuleUpdate mutation bug - unexpected Acc... (#461213 - closed)

Improve ProtectedRefAccess#humanize logic

Prior to this change ProtectedRefAccess#humanize would return nil values for user and group type records where user or group respectively, were nil.

This can happen when user_id/group_id is specified but user/group has not been loaded or doesn't exist.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Joe Woodward

Merge request reports