Skip to content

GitLab pages: Stricter validation of custom page domain

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

  • Related to #467235
  • Extending the test suite to cover more domain name entries
  • Ensuring that only valid top-level domain names are accepted
  • Adding an alert

🛠 with at Siemens

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

MR Checklist (@gerardo-navarro)

Screenshots or screen recordings

Before After
grafik grafik
example.invalid-tld was accepted grafik
domain name example (without the tld .com) grafik grafik
grafik grafik

How to set up and validate locally

  1. Go to the page for creating a new domain: http://gdk.test:3000/flightjs/Flight/pages/domains/new
  2. Try out different domain names, e.g. example, example.invalid-tld, https://domain-name-with-protocol-information.com, etc.
Edited by Gerardo Navarro

Merge request reports

Loading