Skip to content

Remove name field from funnels definition

Halil Coban requested to merge 462390-remove-name-field-from-funnels-schema into master

What does this MR do and why?

This MR replaces usage of name attribute from the Funnel YAML definition with the file name. This way it's compatible with visualization definitions.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist.

It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Funnel definition Clickhouse record
Funnel file name original_funnel Screenshot_2024-06-12_at_20.41.34 Screenshot_2024-06-12_at_20.42.19
Funnel file name renamed_funnel Screenshot_2024-06-12_at_20.43.00 Screenshot_2024-06-12_at_20.43.12
Deleted - No funnel definition in repo No record in DB

How to set up and validate locally

  1. Create a project and onboard product analytics
  2. Create a funnel definition in .gitlab/analytics/funnels directory
  3. Query the DB, you should have a record with the name generated from the file name

Related to #462390 (closed)

Edited by Halil Coban

Merge request reports

Loading