Skip to content

Manually add GlLabel styles to notify enhanced stylesheet

Scott de Jonge requested to merge generate-css-that-is-safe-for-email-clients into master

What does this MR do and why?

Add GlLabel styles manually to notify_enhanced.scss:

Steps

  1. Generate stylesheets yarn run build:css
  2. Copy output of gl-label styles from /app/assets/builds/notify_enhanced.css to app/assets/stylesheets/notify_enhanced.scss
  3. Update to remove redundant styles:
    • Remove @media(forced-colors: active) styles to resolve border in email issue
    • Remove :focus/:hover/:active styles as these won't be inlined
    • Remove .gl-label-close styles as the close button shouldn't render in email
    • Remove .gl-label-tooltip-title styles
    • Remove duplicate display property on .gl-label .gl-label-text, .gl-label .gl-label-text-scoped
  4. Update colors:
    • Update #1f1e24 to $gray-950
    • Update #fff to $white

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
gl-label-before.css gl-label-after.scss

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports