Skip to content

Add project_id to merge_request_diff_files_99208b8fac

Kerri Miller requested to merge 464109-add-project_id-to-merge_request_diff_files_99208b8fac into master

What does this MR do and why?

Adds project_id to merge_request_diff_files_99208b8fac as a desired sharding key for eventual backfill.

Database

Up

SQL 
main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 20973
main: == [advisory_lock_connection] object_id: 128100, pg_backend_pid: 21008
main: == 20240611231834 AddProjectIdToMergeRequestDiffFiles99208b8fac: migrating ====
main: -- add_column(:merge_request_diff_files_99208b8fac, :project_id, :bigint)
main:    -> 0.0012s
main: == 20240611231834 AddProjectIdToMergeRequestDiffFiles99208b8fac: migrated (0.0040s)

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 25783
main: == [advisory_lock_connection] object_id: 131100, pg_backend_pid: 25818
main: == 20240611234401 AddMergeRequestDiffFiles99208b8facProjectIdFk: migrating ====
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0012s
main: -- execute("SET statement_timeout TO 0")
main:    -> 0.0001s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0039s
main: -- execute("RESET statement_timeout")
main:    -> 0.0002s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1000000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1000000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1200000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1200000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1400000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0006s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1400000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1600000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0009s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1600000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1800000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0009s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1800000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2000000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0006s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2000000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_200000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_200000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2200000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0008s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2200000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_400000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_400000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_600000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_600000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_800000001 ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0006s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_800000001 VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0006s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE merge_request_diff_files_99208b8fac ADD CONSTRAINT fk_rails_ebcce501f5 FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE ;")
main:    -> 0.0040s
main: -- execute("ALTER TABLE merge_request_diff_files_99208b8fac VALIDATE CONSTRAINT fk_rails_ebcce501f5;")
main:    -> 0.0002s
main: == 20240611234401 AddMergeRequestDiffFiles99208b8facProjectIdFk: migrated (0.1801s)

main: == [advisory_lock_connection] object_id: 130820, pg_backend_pid: 83744
main: == 20240612110359 IndexRequestDiffFiles9908b8facOnProjectId: migrating ========
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_name_exists?(:merge_request_diff_files_99208b8fac, "index_merge_request_diff_files_99208b8fac_on_project_id")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1", :project_id, {:name=>"index_3d19086f0d", :algorithm=>:concurrently})
main:    -> 0.0050s
main: -- execute("SET statement_timeout TO 0")
main:    -> 0.0003s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1", :project_id, {:name=>"index_3d19086f0d", :algorithm=>:concurrently})
main:    -> 0.0038s
main: -- execute("RESET statement_timeout")
main:    -> 0.0006s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1000000001", :project_id, {:name=>"index_a60a0da57f", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1000000001", :project_id, {:name=>"index_a60a0da57f", :algorithm=>:concurrently})
main:    -> 0.0015s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1200000001", :project_id, {:name=>"index_4d7881efb2", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1200000001", :project_id, {:name=>"index_4d7881efb2", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1400000001", :project_id, {:name=>"index_0858acd8eb", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1400000001", :project_id, {:name=>"index_0858acd8eb", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1600000001", :project_id, {:name=>"index_f31bee44f9", :algorithm=>:concurrently})
main:    -> 0.0011s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1600000001", :project_id, {:name=>"index_f31bee44f9", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1800000001", :project_id, {:name=>"index_2b8628c78f", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_1800000001", :project_id, {:name=>"index_2b8628c78f", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2000000001", :project_id, {:name=>"index_f6d7e9c053", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2000000001", :project_id, {:name=>"index_f6d7e9c053", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_200000001", :project_id, {:name=>"index_db9f210e57", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_200000001", :project_id, {:name=>"index_db9f210e57", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2200000001", :project_id, {:name=>"index_2f0392f65d", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_2200000001", :project_id, {:name=>"index_2f0392f65d", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_400000001", :project_id, {:name=>"index_e3f72a3764", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_400000001", :project_id, {:name=>"index_e3f72a3764", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_600000001", :project_id, {:name=>"index_c9656f4cdc", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_600000001", :project_id, {:name=>"index_c9656f4cdc", :algorithm=>:concurrently})
main:    -> 0.0011s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_800000001", :project_id, {:name=>"index_51e3b62997", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_files_99208b8fac_800000001", :project_id, {:name=>"index_51e3b62997", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- add_index(:merge_request_diff_files_99208b8fac, :project_id, {:name=>"index_merge_request_diff_files_99208b8fac_on_project_id"})
main:    -> 0.0013s
main: == 20240612110359 IndexRequestDiffFiles9908b8facOnProjectId: migrated (0.1014s)

Down

SQL ```sql main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 83724 main: == 20240612110359 IndexRequestDiffFiles9908b8facOnProjectId: reverting ======== main: -- transaction_open?(nil) main: -> 0.0000s main: -- index_name_exists?(:merge_request_diff_files_99208b8fac, "index_merge_request_diff_files_99208b8fac_on_project_id") main: -> 0.0115s main: -- transaction_open?(nil) main: -> 0.0000s main: -- remove_index(:merge_request_diff_files_99208b8fac, {:name=>"index_merge_request_diff_files_99208b8fac_on_project_id"}) main: -> 0.0012s main: == 20240612110359 IndexRequestDiffFiles9908b8facOnProjectId: reverted (0.0301s)

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 25783 main: == 20240611234401 AddMergeRequestDiffFiles99208b8facProjectIdFk: reverting ==== main: -- transaction_open?(nil) main: -> 0.0000s main: -- remove_foreign_key(:merge_request_diff_files_99208b8fac, {:column=>:project_id}) main: -> 0.0101s main: == 20240611234401 AddMergeRequestDiffFiles99208b8facProjectIdFk: reverted (0.0517s)

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 20973 main: == 20240611231834 AddProjectIdToMergeRequestDiffFiles99208b8fac: reverting ==== main: -- remove_column(:merge_request_diff_files_99208b8fac, :project_id, :bigint) main: -> 0.0011s main: == 20240611231834 AddProjectIdToMergeRequestDiffFiles99208b8fac: reverted (0.0060s)


</details>



Related to #464109
Edited by Kerri Miller

Merge request reports