Skip to content

Add project_id to merge_request_diff_commits_b5377a7a34

What does this MR do and why?

Adds project_id to merge_request_diff_commits_b5377a7a34 as a desired sharding key for eventual backfill.

Database

Up

SQL
main: == [advisory_lock_connection] object_id: 127740, pg_backend_pid: 15243
main: == 20240611230232 AddProjectIdToMergeRequestDiffCommitsB5377a7a34: migrating ==
main: -- add_column(:merge_request_diff_commits_b5377a7a34, :project_id, :bigint)
main:    -> 0.0009s
main: == 20240611230232 AddProjectIdToMergeRequestDiffCommitsB5377a7a34: migrated (0.0083s)
main: == [advisory_lock_connection] object_id: 127740, pg_backend_pid: 15243

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 28404
main: == [advisory_lock_connection] object_id: 131100, pg_backend_pid: 28431
main: == 20240612000059 AddMergeRequestDiffCommitsB5377a7a34ProjectIdFk: migrating ==
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0015s
main: -- execute("SET statement_timeout TO 0")
main:    -> 0.0002s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0036s
main: -- execute("RESET statement_timeout")
main:    -> 0.0003s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1000000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1000000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1200000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1200000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1400000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0006s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1400000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1600000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0008s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1600000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1800000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0009s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1800000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2000000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0007s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2000000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_200000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0006s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_200000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2200000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0010s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2200000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_400000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0008s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_400000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_600000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0009s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_600000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_800000001 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE NOT VALID;")
main:    -> 0.0008s
main: -- execute("ALTER TABLE gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_800000001 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0007s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- execute("ALTER TABLE merge_request_diff_commits_b5377a7a34 ADD CONSTRAINT fk_rails_055a94ee7c FOREIGN KEY (project_id) REFERENCES projects (id) ON DELETE CASCADE ;")
main:    -> 0.0034s
main: -- execute("ALTER TABLE merge_request_diff_commits_b5377a7a34 VALIDATE CONSTRAINT fk_rails_055a94ee7c;")
main:    -> 0.0002s
main: == 20240612000059 AddMergeRequestDiffCommitsB5377a7a34ProjectIdFk: migrated (0.1808s)

main: == [advisory_lock_connection] object_id: 131100, pg_backend_pid: 28431

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 86044
main: == [advisory_lock_connection] object_id: 130820, pg_backend_pid: 86065
main: == 20240612160008 IndexRequestDiffCommitsB5377a7a34OnProjectId: migrating =====
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_name_exists?(:merge_request_diff_commits_b5377a7a34, "index_merge_request_diff_commits_b5377a7a34_on_project_id")
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1", :project_id, {:name=>"index_f0bda40e87", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- execute("SET statement_timeout TO 0")
main:    -> 0.0002s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1", :project_id, {:name=>"index_f0bda40e87", :algorithm=>:concurrently})
main:    -> 0.0037s
main: -- execute("RESET statement_timeout")
main:    -> 0.0003s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1000000001", :project_id, {:name=>"index_530e5a157e", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1000000001", :project_id, {:name=>"index_530e5a157e", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1200000001", :project_id, {:name=>"index_e7c99cfa55", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1200000001", :project_id, {:name=>"index_e7c99cfa55", :algorithm=>:concurrently})
main:    -> 0.0012s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1400000001", :project_id, {:name=>"index_432eac6331", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1400000001", :project_id, {:name=>"index_432eac6331", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1600000001", :project_id, {:name=>"index_e2b5248a05", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1600000001", :project_id, {:name=>"index_e2b5248a05", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1800000001", :project_id, {:name=>"index_7b6e36bcc2", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_1800000001", :project_id, {:name=>"index_7b6e36bcc2", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2000000001", :project_id, {:name=>"index_726253890f", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2000000001", :project_id, {:name=>"index_726253890f", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_200000001", :project_id, {:name=>"index_61eff821f2", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_200000001", :project_id, {:name=>"index_61eff821f2", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2200000001", :project_id, {:name=>"index_4c70289662", :algorithm=>:concurrently})
main:    -> 0.0007s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_2200000001", :project_id, {:name=>"index_4c70289662", :algorithm=>:concurrently})
main:    -> 0.0009s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_400000001", :project_id, {:name=>"index_7a436394e2", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_400000001", :project_id, {:name=>"index_7a436394e2", :algorithm=>:concurrently})
main:    -> 0.0012s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_600000001", :project_id, {:name=>"index_7a869a0ddf", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_600000001", :project_id, {:name=>"index_7a869a0ddf", :algorithm=>:concurrently})
main:    -> 0.0010s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_exists?("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_800000001", :project_id, {:name=>"index_94bfc569d6", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- add_index("gitlab_partitions_dynamic.merge_request_diff_commits_b5377a7a34_800000001", :project_id, {:name=>"index_94bfc569d6", :algorithm=>:concurrently})
main:    -> 0.0008s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- add_index(:merge_request_diff_commits_b5377a7a34, :project_id, {:name=>"index_merge_request_diff_commits_b5377a7a34_on_project_id"})
main:    -> 0.0011s
main: == 20240612160008 IndexRequestDiffCommitsB5377a7a34OnProjectId: migrated (0.0609s)

Down

SQL
main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 86044
main: == 20240612160008 IndexRequestDiffCommitsB5377a7a34OnProjectId: reverting =====
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- index_name_exists?(:merge_request_diff_commits_b5377a7a34, "index_merge_request_diff_commits_b5377a7a34_on_project_id")
main:    -> 0.0074s
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- remove_index(:merge_request_diff_commits_b5377a7a34, {:name=>"index_merge_request_diff_commits_b5377a7a34_on_project_id"})
main:    -> 0.0010s
main: == 20240612160008 IndexRequestDiffCommitsB5377a7a34OnProjectId: reverted (0.0282s)

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 28404
main: == 20240612000059 AddMergeRequestDiffCommitsB5377a7a34ProjectIdFk: reverting ==
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: -- remove_foreign_key(:merge_request_diff_commits_b5377a7a34, {:column=>:project_id})
main:    -> 0.0101s
main: == 20240612000059 AddMergeRequestDiffCommitsB5377a7a34ProjectIdFk: reverted (0.0490s)

main: == [advisory_lock_connection] object_id: 127280, pg_backend_pid: 14932
main: == 20240611230232 AddProjectIdToMergeRequestDiffCommitsB5377a7a34: reverting ==
main: -- remove_column(:merge_request_diff_commits_b5377a7a34, :project_id, :bigint)
main:    -> 0.0016s
main: == 20240611230232 AddProjectIdToMergeRequestDiffCommitsB5377a7a34: reverted (0.0079s)

Related to #464108

Edited by Kerri Miller

Merge request reports