Skip to content

Geo: Support replicating uploads, LFS objects, and artifacts in Object Storage

Gabriel Mazetto requested to merge 10586-geo-file-replication-refactor into master

What does this MR do?

  • Refactor file replication
  • Makes possible to handle transfers from/to object storage

remaining tasks:

  • Investigate/fix current failed specs
  • Backport to CE, code that changed in the CE codebase (not needed anymore)
  • Cover BaseTransfer new methods in specs
  • Manually test all three replicable items on a test instance with an omnibus package (to ensure we are not missing anything)
  • Double check we are not missing any custom Proxy configuration as we changed HTTP libraries
  • Please merge !16382 (merged) before, and then change this MR to target master.

items that can come afterwards as separate issues:

  • Investigate if we can refactor something else in BaseTransfer new object storage method => Mike: I assume this was referring to #33266

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #10586 (closed)

Edited by Michael Kozono

Merge request reports