Skip to content

Use client specific errors and handle existing token in cng orchestrator

Andrejs Cunskis requested to merge andrey-fix-token-upgrade into master

What does this MR do and why?

  • Correctly handle token creation when running cng upgrade rather than fresh install.
  • Sync test-on-cng rules with the rest of the e2e pipelines and avoid triggering test-on-cng without assets build jobs when updating only orchestrator code

Part of: gitlab-org/quality/quality-engineering/team-tasks#2570 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

❯ cng create deployment kind
Creating cluster 'gitlab'
  cluster 'gitlab' already exists, skipping!
Creating CNG deployment 'gitlab'
[✔] running pre-deployment setup ... done
Adding gitlab helm chart 'https://charts.gitlab.io'
helm chart repo already exists, updating
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "gitlab" chart repository
Update Complete. ⎈Happy Helming!⎈
Creating namespace 'gitlab'
namespace already exists, skipping
Creating gitlab license secret
`QA_EE_LICENSE|EE_LICENSE` variable is not set, skipping
Creating admin user initial password secret
secret/gitlab-initial-root-password configured
Creating pre-receive hook
configmap/pre-receive-hook unchanged
[✔] running helm deployment ... done
Upgrading helm release 'gitlab' in namespace 'gitlab'
Release "gitlab" has been upgraded. Happy Helming!
NAME: gitlab
LAST DEPLOYED: Tue Jun 11 15:15:29 2024
NAMESPACE: gitlab
STATUS: deployed
REVISION: 4
NOTES:
=== CRITICAL
The following charts are included for evaluation purposes only. They will not be supported by GitLab Support
for production workloads. Use Cloud Native Hybrid deployments for production. For more information visit
https://docs.gitlab.com/charts/installation/index.html#use-the-reference-architectures.
- PostgreSQL
- Redis
- Gitaly
- MinIO

=== NOTICE
The minimum required version of PostgreSQL is now 13. See https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/doc/installation/upgrade.md for more details.

=== WARNING
Automatic TLS certificate generation with cert-manager is disabled.
One or more of the components does not have a TLS certificate Secret configured.
As a result, Self-signed certificates were generated for these components.

You may retrieve the CA root for these certificates from the `gitlab-wildcard-tls-ca` secret, via the following command. It can then be imported to a web browser or system store.

  kubectl get secret gitlab-wildcard-tls-ca -ojsonpath='{.data.cfssl_ca}' | base64 --decode > gitlab.172.16.123.1.nip.io.ca.pem

If you do not wish to use self-signed certificates, please set the following properties:
- global.ingress.tls.secretName
OR all of:
- global.ingress.tls.enabled (set to `true`)
- gitlab.webservice.ingress.tls.secretName
- registry.ingress.tls.secretName
- minio.ingress.tls.secretName
- gitlab.kas.ingress.tls.secretName
Deployment successful and app is available via: http://gitlab.172.16.123.1.nip.io
[✔] running post-deployment setup ... done
Creating admin user personal access token
Token already exists, skipping!

How to set up and validate locally

Run cng create deployment kind twice

Edited by Andrejs Cunskis

Merge request reports