Skip to content
Snippets Groups Projects

Migrate groups overview to filtered search and sort

What does this MR do and why?

Related to #437013 (closed)

The grouptenant scale team is working on unifying all of the groups/projects list views to have the same UX. This MR implements the filtered search and sort bar on the group overview page.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Desktop

Before After
Screenshot_2024-06-11_at_11.35.19_AM Screenshot_2024-06-11_at_11.33.46_AM

Mobile

Before After
Screenshot_2024-06-11_at_11.35.35_AM Screenshot_2024-06-11_at_11.34.07_AM

How to set up and validate locally

  1. Go to a group that has subgroups and projects
  2. Use the search and sort
Edited by Peter Hegman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Hegman changed milestone to %17.1

    changed milestone to %17.1

  • 2 Warnings
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    testid selectors

    The following changed lines in this MR contain testid selectors:

    app/assets/javascripts/groups/components/overview_tabs.vue

    -              data-testid="groups-filter-field"
    -              data-testid="group_sort_by_dropdown"

    If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

    For the list of known failures please refer to the latest pipeline triage issue.

    If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

    Reviewer roulette

    Category Reviewer Maintainer
    frontend @andr3 profile link current availability (UTC+1, 8 hours ahead of author) @ohoral profile link current availability (UTC+0, 7 hours ahead of author)
    QA @vishal.s.patel profile link current availability (UTC+12, 19 hours ahead of author) Maintainer review is optional for QA
    test for spec/features/* @alexbuijs profile link current availability (UTC+2, 9 hours ahead of author) Maintainer review is optional for test for spec/features/*
    UX @mnichols1 profile link current availability (UTC-4, 3 hours ahead of author) Maintainer review is optional for UX

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 1447ec85 and 8d9e0db3

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.36 MB 4.36 MB - 0.0 %
    mainChunk 3.32 MB 3.32 MB - 0.0 %

    :fearful: Significant Growth: 2

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.groups.details 548.93 KB 671.06 KB +122.13 KB 22.2 %
    pages.groups.show 651.62 KB 770.13 KB +118.52 KB 18.2 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @pgascouvaillancourt, @sdejonge or @thutterer) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 1447ec85. So we have used data from: 173d9275.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Peter Hegman added 1 commit

    added 1 commit

    • c44afb73 - Migrate groups overview to filtered search and sort

    Compare with previous version

  • Peter Hegman added 1 commit

    added 1 commit

    • 6db2dffd - Migrate groups overview to filtered search and sort

    Compare with previous version

  • A deleted user added QA label

    added QA label

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 8d9e0db3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 121    | 0      | 11      | 0     | 132   | ✅     |
    | Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Verify      | 30     | 0      | 2       | 0     | 32    | ✅     |
    | Plan        | 56     | 0      | 2       | 0     | 58    | ✅     |
    | Govern      | 65     | 0      | 0       | 0     | 65    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 338    | 0      | 28      | 0     | 366   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 8d9e0db3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Manage      | 2      | 0      | 8       | 0     | 10    | ✅     |
    | Verify      | 55     | 0      | 11      | 0     | 66    | ✅     |
    | Create      | 139    | 0      | 15      | 0     | 154   | ✅     |
    | Package     | 23     | 0      | 15      | 0     | 38    | ✅     |
    | Data Stores | 34     | 0      | 9       | 0     | 43    | ✅     |
    | Plan        | 83     | 0      | 6       | 0     | 89    | ✅     |
    | Govern      | 79     | 0      | 9       | 0     | 88    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Fulfillment | 2      | 0      | 24      | 0     | 26    | ✅     |
    | Secure      | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 435    | 0      | 118     | 0     | 553   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 8d9e0db3

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Govern         | 108    | 1      | 8       | 1     | 117   | ❌     |
    | Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Manage         | 30     | 0      | 15      | 0     | 45    | ✅     |
    | Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
    | Data Stores    | 47     | 0      | 10      | 0     | 57    | ✅     |
    | Verify         | 55     | 0      | 11      | 0     | 66    | ✅     |
    | Create         | 425    | 0      | 45      | 2     | 470   | ✅     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Fulfillment    | 4      | 0      | 24      | 0     | 28    | ✅     |
    | Plan           | 88     | 0      | 6       | 0     | 94    | ✅     |
    | Package        | 31     | 0      | 14      | 4     | 45    | ✅     |
    | Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
    | Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Ai-powered     | 1      | 0      | 1       | 1     | 2     | ✅     |
    | Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure         | 3      | 0      | 1       | 0     | 4     | ✅     |
    | ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 822    | 1      | 156     | 8     | 979   | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
  • Peter Hegman added 1 commit

    added 1 commit

    • 1b153c9e - Migrate groups overview to filtered search and sort

    Compare with previous version

  • Peter Hegman added 1 commit

    added 1 commit

    • 2278ebd5 - Migrate groups overview to filtered search and sort

    Compare with previous version

  • Peter Hegman changed the description

    changed the description

  • Peter Hegman added 1 commit

    added 1 commit

    • c04cdc74 - Migrate groups overview to filtered search and sort

    Compare with previous version

  • Peter Hegman requested review from @mnichols1

    requested review from @mnichols1

  • Peter Hegman
  • Peter Hegman requested review from @dzubova

    requested review from @dzubova

  • Peter Hegman
  • requested review from @vishal.s.patel

  • Vishal Patel approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Diana Zubova approved this merge request

    approved this merge request

  • Diana Zubova requested review from @zcuddy and removed review request for @dzubova

    requested review from @zcuddy and removed review request for @dzubova

  • Mike Nichols approved this merge request

    approved this merge request

  • Mike Nichols removed review request for @mnichols1

    removed review request for @mnichols1

  • Peter Hegman added 1 commit

    added 1 commit

    • 037566f0 - Prevent filtered search from submitting when value is the same

    Compare with previous version

  • Peter Hegman
  • Peter Hegman
  • Peter Hegman
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy removed review request for @zcuddy

    removed review request for @zcuddy

  • Peter Hegman added 1158 commits

    added 1158 commits

    Compare with previous version

  • Peter Hegman reset approvals from @vishal.s.patel by pushing to the branch

    reset approvals from @vishal.s.patel by pushing to the branch

  • Peter Hegman added 1 commit

    added 1 commit

    • 8d9e0db3 - Change how we prevent duplicate router calls

    Compare with previous version

  • Peter Hegman requested review from @zcuddy

    requested review from @zcuddy

  • Zack Cuddy resolved all threads

    resolved all threads

  • Zack Cuddy approved this merge request

    approved this merge request

  • added pipelinetier-3 label and removed pipelinetier-2 label

    • Resolved by Zack Cuddy

      Before you set this MR to auto-merge

      This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

      Before you resolve this discussion, please check the following:

      • You are the last maintainer of this merge request
      • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
      • This pipeline is recent enough (created in the last 8 hours)

      If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.

      See pipeline tiers and merging a merge request for more details.

  • Zack Cuddy resolved all threads

    resolved all threads

  • Zack Cuddy enabled automatic add to merge train when the pipeline for 65ff64ca succeeds

    enabled automatic add to merge train when the pipeline for 65ff64ca succeeds

  • Zack Cuddy cancelled automatic add to merge train

    cancelled automatic add to merge train

  • Zack Cuddy enabled automatic add to merge train when the pipeline for 8e4e5ade succeeds

    enabled automatic add to merge train when the pipeline for 8e4e5ade succeeds

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading