Skip to content

Fixes whitespace only comments not being able to be updated

Phil Hughes requested to merge ph/editDiffWhitespaceCommentFix into master

What does this MR do and why?

This fixes a bug where comments left on an unchanged whitespace diff would throw an error when trying to update. This is caused by the position property being sent in the request to update but it does not include the ignore_whitespace_change property.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  • Create a comment on a diff when Show whitespace changes on an unchanged line that would exist when the Show whitespace changes is checked
  • Refresh the page on the overview tab
  • Edit the comment
  • Comment should be saved

Merge request reports