Skip to content

Align pipeline config strategy selector with schema

What does this MR do and why?

This MR renames override_project_ci property in Pipeline execution policies to pipeline_config_strategy to match the backend schema.

Requires backend changes from !155479 (merged) to be able to edit or commit a new policy.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Policy new / edit:

CleanShot_2024-06-06_at_09.43.27

Commit changes:

CleanShot_2024-06-06_at_09.45.46

Values validation:

CleanShot_2024-06-06_at_10.32.06

How to set up and validate locally

note: From the step 6., backend changes from !155479 (merged) are required.

  1. Enable the feature flag:
    Feature.enable(:pipeline_execution_policy_type)
  2. Go to a project and create a new Pipeline execution policy
  3. The strategy should default to inject_ci and it should be possible to change it to override_project_ci
  4. Go to .yaml mode and try to enter a different, invalid value
  5. The rule mode should be disabled
  6. Change the value back to a valid one, commit changes and merge
  7. Edit the policy
  8. The correct strategy should be pre-selected

Related to #464088 (closed)

Edited by Martin Čavoj

Merge request reports