Skip to content

Take broadcast message height into account in board height

Chad Lavimoniere requested to merge 460525-board-height-should-take-consideration-of-banners into master

What does this MR do and why?

Measure the total height of all the broadcast messages that are displayed, then use that value in a CSS variable that is used to calculate the height of the board.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screen_Recording_2024-06-04_at_17.03.03 Screen_Recording_2024-06-04_at_17.04.36

How to set up and validate locally

  1. On the master branch of the GDK, create one or more broadcast messages (http://gdk.test:3000/admin/broadcast_messages)
  2. Visit a board
  3. You will see that the board page is vertically scrollable by the total height of all the broadcast message banners
  4. Check out this branch
  5. Reload the board (you may need to run a bin/rake db:migrate and/or restart the gdk when switching branches)
  6. You will see that the page does not have any vertical scroll, the board fills the correct amount of space between the bottom of the broadcast message banners and the bottom of the viewport

Related to #460525 (closed)

Related to #452225 (closed)

Edited by Chad Lavimoniere

Merge request reports