Skip to content

Don't show tooltip on scroll

Annabel Dunstone Gray requested to merge viewed-file-checkbox into master

What does this MR do and why?

This MR makes sure the tooltips on the MR diffs files don't stay active when you scroll the page. Because we have lots of sticky elements on the page we need to remove tooltips when scrolling, otherwise they will look like they're detached from the diff file when scrolling.

This MR also hides toggle review tooltip when the checkbox is clicked.

Screenshots or screen recordings

Before After
tooltipbefore tooltipafter
Before After
Screen_Recording_2024-06-10_at_22.19.34 Screen_Recording_2024-06-10_at_22.23.44

How to set up and validate locally

  1. Go to merge request > changes
  2. Click Viewed on some files
  3. The tooltip should be hidden once you click the checkbox
  1. Go to merge request > changes
  2. Scroll a bit so the elements become sticky
  3. Focus 'Viewed' checkbox
  4. Scroll the page again
  5. The tooltip should disappear

Links

Edited by Stanislav Lashmanov

Merge request reports