Skip to content

Release the change in the PAT last used service

David Fernandez requested to merge 462823-feature-flag-cleanup into master

☂ Context

In #462379 (comment 1913877979), we noticed that on GET API requests we could stick to primary.

Turned out that, there is a service that will bump the last_used_at timestamp of PATs. This update being a write, it will trigger the primary sticking.

In Disable sticky writes in the PAT last used service (!153707 - merged), we updated the service to not stick to primary.

This service being quite heavily used (every time we authenticate with a PAT), we used a feature flag: #462823 (closed).

That flag was globally enabled last week (at the time of this writing). We don't have any issue reported, we can thus, cleanup this feature flag. That is this MR.

🔬 What does this MR do and why?

  • Cleanup the disable_sticky_writes_for_pat_last_used feature flag.
  • update the related specs.

🏁 MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

✅

🦄 Screenshots or screen recordings

🤷

⚙ How to set up and validate locally

!153707 (merged)

Edited by David Fernandez

Merge request reports