Remove Vue set for vue 3 migration
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR partially resolves #452467 (closed)
What was cleaned up from epic:
- Remove
Vue.set
Vue set is no longer supported in VUE 3
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
NO VISUAL CHANGES
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout branch
- Run test locally
- Or just check in pipeline
- Run it also with
VUE_VERSION=3 yarn jest --watch
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @arfedoro
added pipelinetier-1 label
2 Warnings This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @kpalchyk
(UTC+3, 1 hour ahead of author)
@deepika.guliani
(UTC+5.5, 3.5 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Artur Fedorov
@aturinske could you please review this small MR?
requested review from @aturinske
- Resolved by Alexander Turinske
@arfedoro
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 841199d9 and 62986d97
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - -0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 841199d9. So we have used data from: 3b29d3f1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded typemaintenance label
removed Category:SAST label
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
enabled automatic add to merge train when the pipeline for 95108fe0 succeeds
@arfedoro Some end-to-end (E2E) tests should run based on the stage label.
Please start the
manual:e2e-test-pipeline-generate
job in theprepare
stage and wait for the tests in thefollow-up:e2e:package-and-test-ee
pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#test-platform
Slack channel.E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 62986d97expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 64 | 0 | 1 | 41 | 65 | ✅ | | Create | 129 | 0 | 10 | 93 | 139 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Verify | 30 | 0 | 2 | 29 | 32 | ✅ | | Plan | 56 | 0 | 2 | 47 | 58 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 345 | 0 | 28 | 264 | 373 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 32b8f55a
changed milestone to %17.1
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label