Skip to content

Make approver to-do and email consistent

Marcin Sedlak-Jakubowski requested to merge msj-approver-todo into master

What does this MR do and why?

Optional Merge Request notifications for approvers (#12855 - closed) added a notification and to-do item for when someone is added as an approver.

I'm still trying to work out how it works (current guess: code owners??). In the meantime, I noticed a discrepancy in the copy of email notification vs to-do item.

Before:

Email To-do item
John Doe has added you as an approver. John Doe have been added as an approver.
image

They're inconsistent and the to-do text is grammatically incorrect.

This MR edits the to-do text.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

I think:

  1. Your user must be named in CODEOWNERS.
  2. Another user must create an MR changing a file that you're a code owner of.
Edited by Marcin Sedlak-Jakubowski

Merge request reports