Skip to content

Delegate GroupHook URL validation to base class

James Nutt requested to merge jnutt/group-hook-validation into master

What does this MR do and why?

Delegate GroupHook URL validation to base class

GroupHook url validation requires urls to be both present and addressable. This prevents usage of masked sections in GroupHook URLs, behaviour which is supported for ProjectHooks.

This MR also removes an outdated sentence from the docs, as masked URL segments are now supported.

Changelog: fixed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image CleanShot_2024-05-31_at_08.45.03_2x

How to set up and validate locally

  1. Create a group.
  2. In the group WebHook settings, create a hook with the following details:
  • URL: https://example.com/hook
  • Mask portions of URL:
    • Sensitive portion: example.com
    • How it looks: url
  • Trigger: emoji events
  1. Save the hook.

Existing behaviour: The hook doesn't save, and a URL validation error is presented. New behaviour: The hook saves and is functional.

Related issue: #460849 (closed)

Edited by James Nutt

Merge request reports