Skip to content

Fix redirection from create form to secret details

Mireya Andres requested to merge ci/fix-create-secret-redirection into master

What does this MR do and why?

!152005 (merged) updates the Secret Manager to use id instead of key for the secret details routes. This breaks the create secret form, where it's supposed to redirect to the secret details page after a successful creation of the secret.

This MR fixes the issue so that it uses the secret.id as the route parameter, instead of the secret.key. Additionally, this also updates the GraphQL response of the client resolver so it saves the required attributes we need to display for !154536 (merged).

Note that the API for Secrets Manager is not yet available, so everything is mocked on the frontend.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screen_Recording_2024-05-31_at_15.06.45

How to set up and validate locally

  1. Enable the ci_tanukey_ui feature flag for your project.
  2. Visit <path-to-project>/-/secrets/new.
  3. Fill in the form and create a secret.
  4. Verify that the form redirects to the secret details page successfully.
Edited by Mireya Andres

Merge request reports