Skip to content

Fix details drawer for merge request policies

Alexander Turinske requested to merge fix-broken-details-drawer-for-zero-actions into master

What does this MR do and why?

Fix details drawer for merge request policies

  • if there are zero actions, the drawer will not render
  • fix with adding a fallback
  • update tests

Changelog: fixed

EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-05-30_at_10.04.07 Screenshot_2024-05-30_at_10.04.23

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a project => Secure => Policies => New policy => Merge request approval policy
  3. Remove all the actions (e.g. ensure there is not a actions section in the yaml). Save the policy and merge it
  4. Navigate to the project => Secure => Policies => Select the policy
  5. Verify the drawer loads

Merge request reports