Skip to content

Frontend: PMG - Separate GraphQL and REST code

Briley Sandlin requested to merge 461918-separate-graphql-code into master

What does this MR do and why?

This is the second step of separating the GraphQL and REST versions of the Pipeline Mini Graph.

>>No code functionality has changed<<

Instead of having logic from both APIs in one directory, we now have 2 different pipeline mini graph instances.

  • the REST version lives at ci/pipeline_mini_graph/legacy_pipeline_mini_graph/legacy_pipeline_mini_graph.vue
  • the GraphQL version lives at ci/pipeline_mini_graph/pipeline_mini_graph.vue

All of the GraphQL logic has been extracted from the REST directory and instead of pipeline_mini_graph.vue being a wrapper file, it is now a parent file. Work on the GraphQL implementation is coming up in Stage 2 of the PMG enhancements, but for now we just want to get ready for that work. There is one file per commit, so it may help to review this by commit

Note on unit tests

I understand that a couple of spec files are missing. Since I am not adding anything new yet and the GraphQL instance is behind a FF, these will be added with the GraphQL work.

Task MR
Move legacy files to new directory !154625 (merged)
Move remaining pmg legacy code to legacy directory 👈 you are here
Create README for PMG TBD

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Make sure you are testing with a project that has a pipeline.Navigate to the following pages and insure that the pipeline mini graph still renders:

Edited by Briley Sandlin

Merge request reports