Skip to content

Fixes auditing non-changing fields for product analytics

Max Woolf requested to merge 464352-fix-product-analytics-settings-audit-events into master

What does this MR do and why?

Fixes a bug introduced by Audit when product analytics settings are changed (!154101 - merged) that would create an audit event stating that a field had been updated, when it had not. This applied to the masked fields.

This MR fixes that bug.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  • Create a new Ultimate namespace and a project within it.
  • In the Project, go to Settings -> Analytics.
  • Expand the "Data Sources" section.
  • Add, update, and remove the values in those 4 fields. Ensure that only the updated fields have audit events created for them.
  • Go to "Secure -> Audit Events" and ensure that the changes have been audited correctly.

Related to #464352 (closed)

Merge request reports