Skip to content

Rename Approvers field and modal title

Samantha Ming requested to merge 65629-rename-approvers into master

Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/65629


What does this MR do?

Rename “Approvers” field and modal title to “Approval rules”

Test Cases

  • Update approvers (title) → Update approval rule
  • Update approvers (button) → Update approval rule
  • Members → Approvers 

image

  • Add approvers (title) → Add approval rule
  • Add approvers (button) → Add approval rule
  • Members → Approvers

image

  • Approvers → Approval rules
  • Members → Approvers
  • Add approvers → Add approval rule  image

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Samantha Ming

Merge request reports