Skip to content

Fix visualization designer showing confirm modal after saving

What does this MR do and why?

This MR clears the visualization designer input fields after succesful saves to resolve Viz designer prompts about unsaved changes righ... (#454706 - closed).

Clearing the input fields resolve two problems with the current implementation:

  • Stops the confirm discard changes modal from triggering when navigating away after saving.
  • Makes the UI less confusing because visualizations can't be edited yet so there's no need to keep the user inputs. See #454706 (comment 1925203268) for more context.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before Before (navigating away) After
image image image

With the analytics_visualization_designer_filtering feature flag enabled.

Before Before (navigating away) After
image image image

How to set up and validate locally

  1. You need a GitLab Ultimate license.
  2. Follow the guide to enable product analytics on your GDK.
  3. Navigate to Project > Analytics > Analytics dashboards and set up product analytics.
  4. Navigate to Project > Analytics > Analytics dashboards and click on the alert CTA to enable custom dashboards.
  5. Navigate to Project > Analytics > Analytics dashboards and click on Visualization designer.
  6. Use the designer to create and save a visualization.

Note: Browse to [GDK_HOST]/rails/features to toggle the analytics_visualization_designer_filtering feature flag.

Related to #454706 (closed)

Edited by Jiaan Louw

Merge request reports