Skip to content

Fix ancestor widget appearance in Epic sidebar

Chad Lavimoniere requested to merge 464091-alignment-of-icon-and-line-in-ancestors-widget-is-incorrect into master

What does this MR do and why?

Changes two things:

  1. Replaces currently-broken gl-bg-inherit utility class with gl-bg-default since the background color being inherited is the default background color
  2. Does not display the vertical line when there is only one ancestor
  3. Corrects the sizing of the div containing the ancestor icon

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image
image image
image image
image image

How to set up and validate locally

  1. Check out this branch locally
  2. Visit an epic that has exactly one ancestor; if necessary, add a child epic to an existing epic that has no ancestors, and visit the new child epic.
  3. You will see that in the Ancestors sidebar widget, there is no gray vertical line
  4. Create a new child epic on the epic and visit that child epic.
  5. This child epic has two ancestors, so now you should see two ancestors in the Ancestors widget, with a gray vertical line connecting their icons. The gray vertical line should appear to stop 4px away from each icon and not intersect with it.

Related to #464091 (closed)

Related to #452225 (closed)

Edited by Chad Lavimoniere

Merge request reports