Use structured logging for DB load balancer
What does this MR do?
Relates to https://gitlab.com/gitlab-org/gitlab-ee/issues/13547 and https://gitlab.com/gitlab-org/gitlab-ee/issues/13548
CE backport of doc changes: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32051
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added database databasereview pending labels
1 Warning This merge request does not refer to an existing milestone. 1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Use the Database changes checklist template or add the appropriate items to the MR description.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
ee/lib/gitlab/database/load_balancing.rb
ee/lib/gitlab/database/load_balancing/host.rb
ee/lib/gitlab/database/load_balancing/load_balancer.rb
ee/lib/gitlab/database/load_balancing/logger.rb
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer database Adam Hegyi ( @ahegyi
)Andreas Brandl ( @abrandl
)backend Etienne Baqué ( @ebaque
)Rémy Coutable ( @rymai
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added groupconfigure [DEPRECATED] label and removed database databasereview pending labels
added backend backstage [DEPRECATED] labels
added database databasereview pending labels
added 2 commits
marked the checklist item Changelog entry as completed
marked the checklist item Documentation created/updated or follow-up review issue created as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Merge request performance guidelines as incomplete
- Resolved by Andreas Brandl
@ansdval or @msmiley could you please take a look at the proposed logs, and if they look good pass this on to a maintainer?
assigned to @msmiley and @ansdval and unassigned @hfyngvason
- Resolved by Andreas Brandl
In terms of consistency of data keys, they all have
event:
,message:
anddb_host:
, which is great.Though the
no_secondaries_available
event does not havedb_host:
but I don't know what to do about that.
added 714 commits
-
ac9499a7...dd7f1df9 - 708 commits from branch
master
- 1f65a892 - Use structured logging for DB load balancer
- eed834de - Remove test for removed method
- 058a4af8 - Fix infinite recursion in serialization
- 39ff8991 - Remove variable from message
- 07e5b5ef - Add docs for new log file
- 688da53c - Add port to logs for visibility on SRV lookups
Toggle commit list-
ac9499a7...dd7f1df9 - 708 commits from branch
changed milestone to %12.3
- Resolved by Andreas Brandl
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Separation of EE specific content as completed
unassigned @rymai
mentioned in issue #13548 (closed)
mentioned in issue #13547 (closed)
unassigned @ansdval and @msmiley
added databaseapproved label and removed databasereview pending label
mentioned in commit c83296ec
Marking for picking into auto deploy as discussed at https://gitlab.slack.com/archives/CMMHQDM0V/p1566941505002000
added Pick into auto-deploy label
removed Pick into auto-deploy label
mentioned in commit a9ce0a62
mentioned in merge request gitlab-cookbooks/gitlab_fluentd!86 (merged)
mentioned in merge request gitlab-cookbooks/gitlab_fluentd!87 (merged)
added groupenvironments label and removed groupconfigure [DEPRECATED] label