Skip to content

Allow any rails backend maintainer to approve CI view changes

drew stachon requested to merge remove-verify-be-reviews-from-ci-views into master

What does this MR do and why?

This MR removes the specific devopsverify approval requirement from view files. In my experience, these changes (without accompanying backend changes) have never caused issues or required me to weigh in with Verify-specific domain knowledge.

The original purpose of requiring devopsverify approval was to avoid people accidentally introducing performance problems in our extremely-high-traffic domain, but that's not the case here and we mostly cause delays to large-scale UI changes.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports