Skip to content

Add alignment to prevent button height to grow

Michael Le requested to merge fix-approval-alignment into master

What does this MR do and why?

Adds gl-align-items-flex-start to the container with the approve button so that it aligns to the top of the page to prevent the button from growing in height.

Example from production

image

Add alignment to prevent button height to grow

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
CleanShot_2024-05-29_at_01.05.55 CleanShot_2024-05-29_at_01.05.15

How to set up and validate locally

  • Get a merge request into a state that it is can be approved
    • Button "Approve" or "Approve additionally" present
  • Change the height of the div next to the button to 200px to simulate lots of content that would increase the height
    • Alternatively you could get many approvals done so that the div area can grow in height
  • Button should align to the top instead of growing in height

Merge request reports