Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • See what's new at GitLab
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 29,115
    • Issues 29,115
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1,162
    • Merge Requests 1,162
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issues
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !15440

"config/prometheus/config/prometheus/common_metrics.yml" did not exist on "master"
Merged
Opened Aug 20, 2019 by Thong Kuah@tkuah🔴4 of 11 tasks completed4/11 tasks
  • Report abuse
Report abuse

Log Prometheus current number of host and index

  • Overview 48
  • Commits 2
  • Pipelines 9
  • Changes 4

What does this MR do?

  1. Log current number of hosts and current index when #initialize is called
  2. Log current number of hosts and current index when #next is called
  3. Log current number of hosts and current index when #hosts= is called

Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/13630

CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32044

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Performance and Testing

Manual QA

Recording of metrics after a GitLab request:

Screen_Recording_2019-08-22_at_11.31.47_AM

See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15440#note_206556427 for how this was tested locally

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Aug 23, 2019 by Ash McKenzie
Assignee
Assign to
12.3
Milestone
12.3
Assign milestone
Time tracking
11
Labels
Observability P1 backend database databasereviewed devopsconfigure documentation feature gitlab.com groupconfigure infradev
Assign labels
  • View project labels
Reference: gitlab-org/gitlab!15440

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.