Skip to content

Remove $highlight-changes-color SCSS variable

Scott de Jonge requested to merge sdejonge-remove-highlight-changes-color into master

What does this MR do and why?

Remove $highlight-changes-color SCSS variable to reduce custom color usage.

Exploration: in settings_panel.vue the this.highlightChanges() method toggles a highlight-changes class on the parent, which should set the background color of .project-repo-select to a light green (dark green in dark mode). This doesn't appear to be applied anymore, the highlight-changes class never appears to be applied, either the logic has changed or functionality has deteched as some point.

Either way, this pattern doesn't appear to be consistent with other settings panels, likewise the color usage isn't aligned with the design system. In the interest of simplifying the implementation, I propose we remove this.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

CleanShot_2024-05-28_at_09.44.41

How to set up and validate locally

  1. Visit Project settings e.g. https://gdk.test:3443/flightjs/Flight/edit#js-general-project-settings
  2. Open Visibility, project features, permissions settings
  3. Toggle controls

Merge request reports