Skip to content

Renaming constants in pending promotions code

Ammar Alakkad requested to merge 433174-refactoring into master

What does this MR do and why?

To ease the review each commit will deal with one refactoring aspect:

  • Rename MEMBER_TYPES to MEMBERS_TAB_TYPES
  • Remove EE_ from EE_ACTION_BUTTONS constant
  • Remove EE_ from GROUPS and PROJECTS APP_OPTIONS

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

You can either run the tests locally, check the pipelines, or follow the steps below to do actual test in gdk:

  • Enable member_promotion_management feature flag
  • Enable ApplicationSetting.first.update!(enable_member_promotion_management: true) application setting
  • Use an Ultimate license, and simulate Ultimate SM setup (e.g. export GITLAB_SIMLATE_SAAS=0 gdk restart)
  • Visit any Group as an owner of that group (e.g. http://127.0.0.1:3000/groups/gitlab-org/-/group_members)
  • Promoting a non-billable GUEST member to a DEVELOPER role (this member should be non-billable on the whole instance, i.e. have a highest role as guest)
  • You should see a banner saying "Role change request was sent to the administrator." — this means a promotion request has been created
  • Navigate to the group's members

Related to #433174 (closed)

Edited by Ammar Alakkad

Merge request reports