Skip to content

Fix quarantined CreateGoogleCloudProvisioningStepsService test

Pedro Pombeiro requested to merge pedropombeiro/446109/fix-quarantined-test into master

What does this MR do and why?

This MR fixes the test quarantined as part of #446109. There seems to be a value returned by Devise.friendly_token(8) that makes the spec fail, but I wasn't able to find out which token value would cause the regex to not match, with the following script:

[21] pry(main)> (0..10_000_000).to_a.any? { deployment_name = "grit-#{Devise.friendly_token(8)}"[0..20 - 1].downcase.tr('_', '-').gsub(/-+$/, ''); puts deployment_name unless deployment_name.match?(Ci::Runners::CreateGoogleCloudProvisioningStepsService::DEPLOYMENT_NAME_REGEXP) }
=> false

I feel it is better to have it non-quarantined and still testing most of the logic, than to have it completely ignored.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Edited by Pedro Pombeiro

Merge request reports