Skip to content

fix: Move modal and drawer out of container style

Deepika Guliani requested to merge dg-fix-modal-in-work-items into master

What does this MR do and why?

Use container queries for modal and drawer, otherwise use media queries.

Container queries break absolute/fixed position things, which broke work item modal, drawer view, and design management detail on work item pages.

Changelog: fixed

This is a regression of !153255 (merged). The following are reasons it is not user facing

  1. Behind FF namespace_level_work_items , since we cannot create work item epics without this FF
  2. Only visible for work item epics and tasks do not have Child items
  3. The opening of the child item in a modal is also behind another epic i.e work_items_mvc_2

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

Screen Recording 2024-05-24 at 7.09.15 PM.mov

Screen Recording 2024-05-24 at 7.04.54 PM.mov

How to set up and validate locally

  1. Enable the FF's namespace_level_work_items and work_items_mvc_2
  2. Open any work item epic
  3. Link a child to the epic
  4. See that the modal is not broken and taking whole screen space

Closes #463531 (closed)

Edited by Simon Knox

Merge request reports