Remove ancient EE::Model and EE::LegacyModel
What does this MR do and why?
Both modules aren't (and weren't?) used at all so they are safe be removed.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
assigned to @splattael
added pipelinetier-1 label
added pipeline:run-all-rspec label
changed milestone to %17.1
added Engineering Productivity backend maintenanceremoval typemaintenance labels
- A deleted user
added development guidelines docsimprovement documentation maintenancerefactor labels and removed maintenanceremoval label
1 Warning 5f97550a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This MR contains docs in the /doc/development directory, but any Maintainer (other than the author) can merge. You do not need tech writer review. Reviewer roulette
Category Reviewer Maintainer backend @jon_jenkins
(UTC-5, 7 hours behind author)
@shinya.maeda
(UTC+9, 7 hours ahead of author)
~"Backend Static Code Analysis" Reviewer review is optional for ~"Backend Static Code Analysis" @ddieulivol
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Shinya Maeda
Can you review this MR?
requested review from @jon_jenkins
requested review from @shinya.maeda and removed review request for @jon_jenkins
added pipeline:mr-approved label
- Resolved by Shinya Maeda
@shinya.maeda
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-3 label and removed pipelinetier-1 label
enabled an automatic merge when the pipeline for abb9a399 succeeds
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 5f97550aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 64 | 0 | 1 | 41 | 65 | ✅ | | Create | 121 | 0 | 10 | 93 | 131 | ✅ | | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Verify | 30 | 0 | 2 | 29 | 32 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Analytics | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 333 | 0 | 29 | 263 | 362 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 4b56fb48
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#6600 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label