Use text-subtle instead of a disabled class for badge img empty
What does this MR do and why?
To address WCAG AA minimum contrast issues, use a different class on the text used in the badge image preview empty state in group or project settings.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Mode | Before | After |
---|---|---|
Light mode | ![]() |
![]() |
Dark mode | ![]() |
![]() |
How to set up and validate locally
- Check out this branch locally
- Go to the General settings on a project and scroll to the
Badges
section - Click "Add badge"
You will see that the text "No image to preview" has an accessible contrast
Closes #22348 (closed)
Related to #452225 (closed)
Merge request reports
Activity
added SLOMissed UX accessibility automation:prevent-auto-close reproduced on GitLab.com severity4 typebug vintage + 1 deleted label
assigned to @clavimoniere
cc @jeldergl
changed milestone to %17.1
added pipelinetier-1 label
mentioned in issue #22348 (closed)
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @bsandlin
(UTC-5, 1 hour behind author)
@rchanila
(UTC+10, 14 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1da45e94 and e7bb43ef
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.31 MB 4.31 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 1da45e94. So we have used data from: 386e9b87.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- e7bb43ef - Use text-subtle instead of a disabled class for badge img empty
- Resolved by Scott de Jonge
@sdejonge can you do a review here?
requested review from @sdejonge
added pipeline:mr-approved label
- Resolved by Scott de Jonge
@sdejonge
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-3 label and removed pipelinetier-1 label