Skip to content

Migrate gl-display-none to gl-hidden

Savas Vedova requested to merge 456624-migrate-gl-display-none-2 into master

What does this MR do and why?

Migrates some of gl-display-none to gl-hidden.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Desktop

Before After
Actions Before_-_Actions_Desktop After_-_Actions_Desktop
Details Before_-_Details_Desktop After_-_Details_Desktop

Mobile

Before After
Actions Before_-_Actions_Mobile After_-_Actions_Mobile
Details Before_-_Details_Mobile After_-_Details_Mobile

How to set up and validate locally

  1. Follow the steps to install 2 GDKs: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/geo.md#easy-installation
  2. Here's an installation guide: https://www.youtube.com/watch?v=R58mgwDwjM8 and a slide deck: https://docs.google.com/presentation/d/1azikV27LO68xobgJ7v399H1ppnLCmtB_kEKl_IMNI0Q/edit#slide=id.g123a13deda8_0_405

Once you have the two GDKs ready:

  1. Go to Admin > Geo Sites
  2. Ensure Desktop and Mobile views are unchanged

Related to #456624

Edited by Zack Cuddy

Merge request reports