Use RemoteMirrors::DestroyService for push mirror deletion API
What does this MR do and why?
Contributes to #455518 (closed)
Problem
Currently, push mirror deletion logic is included in
Projects::UpdateService
. It's error-prone and inconvenient to use
push mirrors.
Solution
Add a RemoteMirrors::DestroyService
to handle push mirror deletion for REST API.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- See API docs: https://docs.gitlab.com/ee/api/remote_mirrors.html#delete-a-remote-mirror
- The result of deletion must be the same (with
use_remote_mirror_destroy_service
FF on and off)
Edited by Vasilii Iakliushin