Skip to content

Respect carraige return in new job log viewer

Kev Kloss requested to merge kkloss-fix-carriage-return-ignored-in-new-job-viewer into master

What does this MR do and why?

This fixes a bug in the new job log viewer where the carriage return character is ignored in lines, which causes all outputs of progress messages (e.g. the git “Counting objects” message) to be rendered in a single line.

This makes the viewer respect the carriage return and only show the latest variation of the message in the log.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a job log that contains message with carriage returns, e.g. a git clone
  2. Open the job log in the viewer
  3. See that the problem is fixed

Merge request reports