Skip to content

Fix merge when checks pass button not showing when changes requested

Phil Hughes requested to merge ph/requestedChangesMWCP into master

What does this MR do and why?

Fixes a bug where the merge when checks pass button would not be visible if the only check that has failed is the requested changes check.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  • Enable merge_when_checks_pass feature flag
  • Enable additional_merge_when_checks_ready feature flag
  • Visit a merge request that is ready to merge
  • Request changes through the review feature
  • Set to auto-merge button should be visible.

Merge request reports