Skip to content

Ensure label text color is used for label filter in MR search bar

Chad Lavimoniere requested to merge 20240520-MR-filter-label-token-text-color into master

What does this MR do and why?

Prevents the filter search bar default value text color from overriding the label text color for label filters that are in the filtered search on MR list page.

NOTE: this MR does not fix an adjacent bug I noticed while addressing this: the x button to remove the label filter currently does not use the correct color in dark mode. That will be addressed separately.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Check out this branch locally
  2. visit the MR list page for a project
  3. use the search bar to filter for a label that should have light text on a dark label color background
  4. You will see that the correct label text color appears in the label filter token in the search bar

Related to #452225

Edited by Chad Lavimoniere

Merge request reports