refactor: Warnings for GlDisclosureDropdown displacement deprecation
What does this MR do and why?
refactor: Warnings for GlDisclosureDropdown displacement deprecation
Related to #462623 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
Merge request reports
Activity
changed milestone to %17.1
assigned to @a_akgun
added 1 commit
- 7cb3889f - GlDisclosureDropdown displacement deprecations
added pipelinetier-1 label
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @rcrespo3
(UTC-4, 7 hours behind author)
@mlunoe
(UTC+2, 1 hour behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 511055d2 and 7cb3889f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.3 MB 4.3 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.settings.remote_development.workspaces.show 269.74 KB 317.17 KB +47.43 KB 17.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for 511055d2. So we have used data from: 543cdb91.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Alper Akgun
@eduardobonet could you pls review this tiny MR?
requested review from @eduardobonet
requested review from @tristan.read and removed review request for @eduardobonet
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Thanks for this @a_akgun, it looks good to me. Approving and kicking off a merge
- Resolved by Tristan Read
@tristan.read
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
enabled an automatic merge when the pipeline for 86c63000 succeeds
enabled an automatic merge when the pipeline for 86c63000 succeeds
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7cb3889fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Create | 120 | 0 | 10 | 93 | 130 | ✅ | | Verify | 31 | 0 | 1 | 30 | 32 | ✅ | | Govern | 64 | 0 | 1 | 41 | 65 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Analytics | 1 | 0 | 1 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 333 | 0 | 28 | 264 | 361 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#314 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#315 (closed)
mentioned in commit e00331d9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label