Skip to content

Draft: Syntax highlighting for Glimmer JS/TS (.gts/.gjs) files

Chris Burgess requested to merge gitlab-community/gitlab:421133-syntax-highlighting-glimmer into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

This MR proposes to add Glimmer syntax highlighting support to Gitlab, via the highlightjs-glimmer NPM package.

This MR is based on changes proposed in !129002 (closed)

NB: This is my first Gitlab Community Fork MR, I'm using this small MR to learn about the new process. Marking DRAFT until I feel it's ready for review, early input is very welcome!

References

Some references:

Tasks

  • MR reports License Compliance - says License Compliance failed loading results? Anything to do here? Comment thread
  • Update highlightjs-glimmer. Original MR has 2.1.0, 2.2.1 is available now.
  • Are custom packages permitted for highlighting?
  • When proposing adding an extra NPM/Yarn dependency, what review processes are required? Is there a quality assessment of the new dependency?

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Chris Burgess

Merge request reports