Skip to content

Encapsulate attributes in MetricDefinition

Jonas Larsen requested to merge j_lar/refactor_metric_definitions into master

What does this MR do and why?

Since MetricDefinition was created and only held path and attributes loaded from the yaml files, things have developed more and more logic has been added which needs access to the data in attributes.

This MR makes attributes private and adds accessor method for the keys that are actually used.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Jonas Larsen

Merge request reports