Skip to content

Display unverified badge for signed commits without a signature

What does this MR do and why?

Contributes to #366364 (closed)

Problem

When a commit signed with a X.509 certificate that has an error, we don't display the signature status at all.

It happens, because we don't store invalid X.509 certificates and signature value is nil for them.

Solution

If the commit has some signature but missing a certificate, we should still display an Unverified badge for these commits.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-07-03_at_16.08.32 Screenshot_2024-07-03_at_15.50.56

How to set up and validate locally

  1. It's hard to verify that locally, because you would need to create an invalid commit with X.509 certificate.
Edited by Vasilii Iakliushin

Merge request reports